-
-
Notifications
You must be signed in to change notification settings - Fork 9
URW-167 Discord verification #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kenneth-W-Chen
wants to merge
19
commits into
develop
Choose a base branch
from
URW-167-discord-verification
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update discord_id field to use same type as in users table Update sample.config with DISCORD_VERIFIED_ROLE_ID constant
Reformatting and reworded some comments
Updates a user entry which was created through the discord verification process (only has the unt_email and discord_id fields) with the website account details instead of making a new user account. This only happens if they sign up with the same email as in unt_email
PHP documentation incorrectly states that it works for UPDATE statements; it does not
Moved the token ratelimit const to the config file since it's used for both the discord and website flows
PHP Storm incorrectly tries to remove the parentheses which causes the issue
…kend issues Plugin doesn't like newly created input fields and changes to the form html
This fix applies to RDMailForm too Added validation
Fix snackbar not disappearing for initial token request Fix token form showing up regardless of verification status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dues/paidpage.dues/paidpage. Afterwards, the Good Standing and Verified roles are added if the user is in good standing and has verified their email.api/discord/bot.phpnotapi/discord/bots/admin.php).DB Changes
discord_verification_tokenstable to store verification tokens.userstable with aunt_emailfield.. If the field isn't null, the user has verified their email.Other changes
usersentry creation during the Discord verification process (if applicable; see notes)config.phpwith Verified role ID and email token generation rate limit (in seconds, so 5 minutes).resultparameter was an XHR instead of the response text. See 071fbb1 for changediscord.phpDiscord bot to add the verified role to a user, similar to what's used for the good standing role.Notes
mysqli::fetch_columnand maybe? other mysqli functions only available in PHP8).api/discord/application-commands/register.phponly needs to be run whenapi/discord/application-commands/commands.jsonchanges. If a new/old command needs to be added/edited, make the changes incommands.jsonand runregister.php. There currently isn't any functionality to delete application commands.usersentry is updated instead of making a new entry. (077128b)script.jschangesTesting
updateOriginalResponse().